Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] feat#76#84#224 로그인/회원가입, 마이페이지 ui, 채팅 스크롤 개선 #225

Merged
merged 4 commits into from
Nov 20, 2024

Conversation

always97
Copy link
Collaborator

@always97 always97 commented Nov 19, 2024

➕ 이슈 번호


🔎 작업 내용

  • 로그인/회원가입 UI
  • 마이페이지 UI
  • 채팅 스크롤 개선

🖼 참고 이미지

  • 마이페이지, 로그인/회원가입 화면

  • 채팅 스크롤 개선


🎯 리뷰 요구사항 (선택)

  • 마이페이지에 들어갈 내용에 대해서는 추가 논의 ex) 포인트

✅ Check List

  • merge할 브랜치의 위치를 확인했나요?
  • Label을 지정했나요?

Copy link
Collaborator

@NewCodes7 NewCodes7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

준우님 어제 수고하셨습니다!!

Copy link
Collaborator

@songbuild00 songbuild00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다! 마이페이지 UI도 괜찮은 것 같습니다 👍🏻

Copy link
Collaborator

@ijun17 ijun17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디자인 깔쌈하네요 고생하셨습니다!

if (isAtBottom && chatBottomRef.current) {
scrollToBottom();
if (isAtBottom) {
requestAnimationFrame(() => scrollToBottom());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requestAnimationFrame 좋습니다 👍

@always97 always97 merged commit 26b57e8 into boostcampwm-2024:dev-fe Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants