[FE] feat#27#221#222 서바이벌 모드 구현 및 게임 종료 후 호스트 변경 구현 #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 유틸함수 추가 - 정답 처리 버그 수정
ijun17
requested review from
songbuild00,
DongHoonYu96,
always97 and
NewCodes7
- 주기적으로 요청하여 offset의 평균값을 계산
NewCodes7
approved these changes
Nov 20, 2024
Comment on lines
+17
to
+19
| offsetTotal += clientTime - res.serverTime; | ||
| offsetCount++; | ||
| offset = Math.floor(offsetTotal / offsetCount); |
There was a problem hiding this comment.
offset을 평균으로 계산하고 있군요!!
네트워크 시간이 매번 달라질 수 있기 때문에 그런거죠? 좋습니다!
songbuild00
approved these changes
Nov 20, 2024
| @@ -70,3 +72,7 @@ socketService.on('endQuizTime', (data) => { | |||
| useQuizeStore.getState().setQuizState(QuizState.END); | |||
| useQuizeStore.getState().setCurrentAnswer(Number(data.answer)); | |||
| }); | |||
|
|
|||
| socketService.on('endGame', () => { | |||
| useQuizeStore.getState().resetQuiz(); | |||
There was a problem hiding this comment.
지금 봤는데, useQuizeStore 중간에 e는 오타인가요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ 이슈 번호
🔎 작업 내용
🖼 참고 이미지
🎯 리뷰 요구사항 (선택)
✅ Check List