[FE] feat#46 선택한 퀴즈셋 서버로 전송 #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 무한 스크롤 기능 개발
DongHoonYu96
approved these changes
Nov 18, 2024
Comment on lines
+222
to
+243
| const clientMessage = await sendToClient( | ||
| client, | ||
| { | ||
| type: 'REQUEST', | ||
| payload: { | ||
| id: requestId, | ||
| url: request.url, | ||
| mode: request.mode, | ||
| method: request.method, | ||
| headers: Object.fromEntries(request.headers.entries()), | ||
| cache: request.cache, | ||
| credentials: request.credentials, | ||
| destination: request.destination, | ||
| integrity: request.integrity, | ||
| redirect: request.redirect, | ||
| referrer: request.referrer, | ||
| referrerPolicy: request.referrerPolicy, | ||
| body: requestBuffer, | ||
| keepalive: request.keepalive, | ||
| }, | ||
| }, | ||
| [requestBuffer], |
Comment on lines
+33
to
+37
| new URLSearchParams([ | ||
| ['search', search], | ||
| ['offset', String(pageParam * SEARCH_COUNT)], | ||
| ['size', String(SEARCH_COUNT)] | ||
| ]) |
Comment on lines
+111
to
+113
| // Bypass all requests when there are no active clients. | ||
| // Prevents the self-unregistered worked from handling requests | ||
| // after it's been deleted (still remains active until the next reload). |
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋ 그 파일이 msw 패키지 설치하고 초기 실행하면 생기는 파일입니다
- 화면 크기 변경 시 플레이어 위치 재조정 - 퀴즈 카운트 다운에는 선택지 보여주지 않음
NewCodes7
approved these changes
Nov 19, 2024
| .then((res) => res.json()) | ||
| .then((res) => { | ||
| const endClientTime = Date.now(); | ||
| const clientTime = (startClientTime + endClientTime) / 2; |
There was a problem hiding this comment.
P3: clientTime을 평균으로 잡으신 이유가 있나요?
const clientTime = startClientTime + (fetch 응답 오는 데까지 걸린 측정 시간)으로 두면 더 정확하지 않을까요?
There was a problem hiding this comment.
평균 시간에 서버에 요청이 도착하는 것으로 가정하고 있습니다
FE/src/hooks/useServerDate.ts
Outdated
| setOffset(clientTime - res.serverTime); | ||
| }); | ||
| }, []); | ||
| const now = useCallback(() => Date.now() + offset, [offset]); |
There was a problem hiding this comment.
P2: offset을 더하는 게 아니라 빼야 하는 거 아닐까요?
예시)
startClientTime = 1
endClientTime = 5
clientTIme = 3
serverTIme = 2
offset 1
보정해야 하는 클라이언트 시각 = clientTime - offset = 3 - 1 = 2 ( = serverTime과 동일)
songbuild00
approved these changes
Nov 19, 2024
always97
approved these changes
Nov 19, 2024
| return ( | ||
| <div className="border border-default component-popup flex justify-center items-center h-[280px] w-[1000px] text-orange-300 font-bold text-7xl"> | ||
| {Math.ceil((currentQuiz.startTime - Date.now()) / 1000)} | ||
| {Math.ceil((currentQuiz.startTime - serverNow()) / 1000)} |
There was a problem hiding this comment.
p2: 1000은 매직넘버로 보입니다 ! 상수화해서 사용하면 좋을것같아요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➕ 이슈 번호
🔎 작업 내용
🖼 참고 이미지
클라이언트 서버 시간 동기화
🎯 리뷰 요구사항 (선택)
✅ Check List