PlaceRepository 테스트 작성 (진행중이지만 리뷰 남겨주세요) #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
5 tasks
koomchang
changed the title
koomchang
changed the title
koomchang
force-pushed
the
feature/#50
branch
from
6b61de9 to
035fb50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More
테스트를 작성해봤는데
spyOn과mockResolvedValue를 통해서 결과값을 넣어두고 테스트를 하는 것 같아서 테스트의 의미가 전혀 없다고 느껴집니다. 아무래도 테스트의 목적과 전혀 다른 방향으로 작성하는 것 같아서 PR을 작성했고 어떤 식으로 변경할 수 있을지에 대해 코멘트를 듣고 싶습니다🕰️ Actual Time of Completion
close #50