지도 삭제/수정, 장소 삭제, 지도 상세보기 UI, 장소 상세보기 UI 구현 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1119wj
requested review from
koomchang,
Miensoap and
hyohyo12
as code owners
koomchang
approved these changes
Nov 18, 2024
Miensoap
approved these changes
Nov 18, 2024
| title: string; | ||
| description: string; | ||
| }; | ||
| type EditVisResponse = { |
There was a problem hiding this comment.
p3. public - private 변경인가요?
줄이지 않는 편이 이해하기 좋아 보여요
Comment on lines
+28
to
+34
| <Marker | ||
| key={place.google_place_id} | ||
| position={{ | ||
| lat: place.location.latitude, | ||
| lng: place.location.longitude, | ||
| }} | ||
| /> |
There was a problem hiding this comment.
p3. 마커에 google place id 를 입력하는 코드가 자주 보이는데,
내부적으로 설정할 수 없을까요?
There was a problem hiding this comment.
상위 fragment에 묶어서 key를 주는 방식으로 수정하겠습니다.
#preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
지도 삭제/수정, 장소 삭제, 지도 상세보기 UI, 장소 상세보기 UI 구현
🙋🏻 More
🕰️ Actual Time of Completion
close #130
close #131
close #132
close #101