map 기능 레포지토리 테스트 작성 #129
Merged
map 기능 레포지토리 테스트 작성 #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyohyo12
requested review from
koomchang,
Miensoap and
1119wj
as code owners
koomchang
approved these changes
Nov 16, 2024
| container = await new MySqlContainer().withReuse().start(); | ||
| dataSource = await initDataSource(container); | ||
| mapRepository = new MapRepository(dataSource); | ||
| await dataSource.getRepository(User).delete({}); |
There was a problem hiding this comment.
q: User 이 상태가 변하는 곳이 있나요? 지우는 이유가 있을까요?
There was a problem hiding this comment.
아하 그러네요 잘 못 적은 것 같슽니다. 수정하겠습니다.
Comment on lines
+27
to
+30
| afterAll(async () => { | ||
| await mapRepository.delete({}); | ||
| await dataSource.getRepository(User).delete({}); | ||
| await dataSource.destroy(); |
There was a problem hiding this comment.
생각해보니 afterAll에서 dataSource를 정리해주는 것은 필요하겠네요! 참고하겠습니다!
Miensoap
approved these changes
Nov 16, 2024
| @@ -0,0 +1,9 @@ | |||
| import { User } from '../../../src/user/entity/user.entity'; | |||
There was a problem hiding this comment.
p3. path alias 설정해 두었으니 사용해 주세요! ( 다른 파일도 동일 )
@src/user/entity/user.entity
There was a problem hiding this comment.
넵!! 수정해서 다음 service 테스트 PR 에 반영하겠습니다!
Comment on lines
+13
to
+17
| let fakeUser1: User; | ||
| let fakeUser2: User; | ||
| beforeAll(async () => { | ||
| fakeUser1 = UserFixture.createUser({ oauthId: 'abc' }); | ||
| fakeUser2 = UserFixture.createUser({ oauthId: 'def' }); |
There was a problem hiding this comment.
q. 항상 유저 두명이 필요한가요?
그렇지 않고 특정 테스트의 조건이라면
테스트와 함께 작성하는 것이 나을 것 같아요
hyohyo12
force-pushed
the
feature/#54
branch
from
1335d0a to
c617348
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🕰️ Actual Time of Completion
close #54