장소 모듈 테스트 작성 (컨트롤러 일부 추가) #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miensoap
requested review from
koomchang,
1119wj and
hyohyo12
as code owners
koomchang
approved these changes
Nov 15, 2024
| expect(results).toEqual([]); | ||
| }); | ||
|
|
||
| it('페이지 크기가 매우 클 경우에도 정상적으로 작동한다', async () => { |
There was a problem hiding this comment.
q: 매우 크다는 기준이 정확하게 뭘까요? 조금 애매한 것 같습니다!
There was a problem hiding this comment.
수정했습니다.
0 이하랑 반대되는 테스트를 만들고 싶었어요 ㅎㅎ;
q. 스크립트에 runInBand 옵션이 없어서 추가했는데 이렇게 사용하는거 맞나요?
There was a problem hiding this comment.
--runInBand 의 alias가 -i입니다!
hyohyo12
approved these changes
Nov 15, 2024
| expect(results).toEqual([]); | ||
| }); | ||
|
|
||
| it('결과가 너무 많을 경우 페이지 크기만큼만 반환한다', async () => { |
There was a problem hiding this comment.
p3. 이 부분 너무 많을 경우보다는 정확한 수치를 입력하는 게 좋지 않을까요??
There was a problem hiding this comment.
여기도 있네요!
페이지 크기를 초과하는 경우로 수정해야겠어요
| PlaceService, | ||
| { | ||
| provide: PlaceRepository, | ||
| useValue: new PlaceRepository(dataSource), |
There was a problem hiding this comment.
q. 저희 service 테스트에서는 repository 모킹해서 진행하는 걸로 정하지 않았나요?
Miensoap
force-pushed
the
feature/#50
branch
2 times, most recently
from
191b42c to
d90800e
Compare
-- runInBand 반영
불명확한 테스트 설명 수정
Miensoap
force-pushed
the
feature/#50
branch
from
9328e37 to
22a42c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🙋🏻 More
일단 컨테이너 사용하도록 해서 서비스 테스트 작성했습니다.
삽질 보관용 커밋
삽질의 흔적입니다 ...
🕰️ Actual Time of Completion
close #50