refactor: 코스 id를 통해 owner id를 조회하는 로직을 만들어서 필요한 부분만 조회할 수 있도록 변경 #83

boostcampwm-2024 · Nov 9, 2024 · 7a5316f · 7a5316f
1 parent 5200c83
commit 7a5316f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/backend/src/course/course.service.ts b/backend/src/course/course.service.ts
@@ -72,6 +72,13 @@ export class CourseService {
     return await CourseDetailResponse.from(map);
   }
 
+  async getCourseOwnerId(courseId: number) {
+    const course = await this.courseRepository.findById(courseId);
+    if (!course) throw new CourseNotFoundException(courseId);
+
+    return course.user.id;
+  }
+
   async createCourse(userId: number, createMapForm: CreateCourseRequest) {
     const user = { id: userId } as User;
     const map = createMapForm.toEntity(user);

diff --git a/backend/src/course/guards/CoursePermissionGuard.ts b/backend/src/course/guards/CoursePermissionGuard.ts
@@ -11,10 +11,10 @@ export class CoursePermissionGuard implements CanActivate {
     const courseId = Number(request.params.id);
     const userId = Number(request.user.userId);
 
-    const course = await this.courseService.getCourseById(courseId);
-    if (course.user.id !== userId) {
+    const course = await this.courseService.getCourseOwnerId(courseId);
+    if (course !== userId) {
       throw new CoursePermissionException(courseId);
     }
-    return course.user.id === userId;
+    return true;
   }
 }