refactor: #84 PR 피드백 반영

에러코드 수정 불필요한 인자 제거 id 타입 캐스팅 없이 사용할 수 있도록 수정
boostcampwm-2024 · Nov 13, 2024 · 025f5b6 · 025f5b6
1 parent ec2adeb
commit 025f5b6
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 14 deletions.
diff --git a/backend/src/auth/AuthUser.decorator.ts b/backend/src/auth/AuthUser.decorator.ts
@@ -17,7 +17,7 @@ export const AuthUser = createParamDecorator(
 );
 
 export interface AuthUser {
-  userId: string;
+  userId: number;
   role: string;
 }
 

diff --git a/backend/src/auth/utils.ts b/backend/src/auth/utils.ts
@@ -2,10 +2,7 @@ const BEARER = 'Bearer';
 const BEARER_REGEX = new RegExp(`^${BEARER}\\s+([A-Za-z0-9\\-._~+\\/=]*)$`);
 
 export function extractBearerToken(header: string): string | null {
-  if (!header) {
-    return null;
-  }
-  const match = header.match(BEARER_REGEX);
+  const match = header?.match(BEARER_REGEX);
   return match ? match[1] : null;
 }
 

diff --git a/backend/src/course/course.controller.ts b/backend/src/course/course.controller.ts
@@ -37,8 +37,7 @@ export class CourseController {
   @Get('/my')
   @UseGuards(JwtAuthGuard)
   async getMyCourseList(@AuthUser() user: AuthUser) {
-    const userId = Number(user.userId);
-    return await this.courseService.getOwnCourses(userId);
+    return await this.courseService.getOwnCourses(user.userId);
   }
 
   @Get('/:id')
@@ -52,14 +51,15 @@ export class CourseController {
     @AuthUser() user: AuthUser,
     @Body() createCourseRequest: CreateCourseRequest,
   ) {
-    const userId = Number(user.userId);
-    return await this.courseService.createCourse(userId, createCourseRequest);
+    return await this.courseService.createCourse(
+      user.userId,
+      createCourseRequest,
+    );
   }
 
   @Put('/:id/places')
   @UseGuards(JwtAuthGuard, CoursePermissionGuard)
   async setPlacesOfCourse(
-    @AuthUser() user: AuthUser,
     @Param('id') id: number,
     @Body() setPlacesOfCourseRequest: SetPlacesOfCourseRequest,
   ) {
@@ -72,7 +72,6 @@ export class CourseController {
   @Patch('/:id/info')
   @UseGuards(JwtAuthGuard, CoursePermissionGuard)
   async updateCourseInfo(
-    @AuthUser() user: AuthUser,
     @Param('id') id: number,
     @Body() updateCourseInfoRequest: UpdateCourseInfoRequest,
   ) {
@@ -83,7 +82,6 @@ export class CourseController {
   @Patch('/:id/visibility')
   @UseGuards(JwtAuthGuard, CoursePermissionGuard)
   async updateCourseVisibility(
-    @AuthUser() user: AuthUser,
     @Param('id') id: number,
     @Body('isPublic') isPublic: boolean,
   ) {
@@ -93,7 +91,7 @@ export class CourseController {
 
   @Delete('/:id')
   @UseGuards(JwtAuthGuard, CoursePermissionGuard)
-  async deleteCourse(@AuthUser() user: AuthUser, @Param('id') id: number) {
+  async deleteCourse(@Param('id') id: number) {
     return await this.courseService.deleteCourse(id);
   }
 }
diff --git a/backend/src/course/exception/CoursePermissionException.ts b/backend/src/course/exception/CoursePermissionException.ts
@@ -4,7 +4,7 @@ import { HttpStatus } from '@nestjs/common';
 export class CoursePermissionException extends BaseException {
   constructor(id: number) {
     super({
-      code: 903,
+      code: 905,
       message: `id:${id} 코스에 대한 권한이 없습니다.`,
       status: HttpStatus.FORBIDDEN,
     });