Record the SMT input size for each split #938
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… regressions in encoding performance
atomb
reviewed
Aug 14, 2024
| @@ -647,6 +653,7 @@ protected override void Send(string s, bool isCommon) | |||
|
|
|||
| if (Process != null) | |||
| { | |||
| SentSize += s.Length; | |||
There was a problem hiding this comment.
It would be lovely if this could only be done from a wrapper around Send, to ensure that it's always incremented. It would be even nicer if the reset to size 0 could be encapsulated somewhere, too, though I remember from working on this code that there isn't a clear place to put it at the moment.
atomb
requested changes
Aug 15, 2024
Test/commandline/xml.bpl
Outdated
| @@ -11,11 +11,11 @@ | |||
| // CHECK: \<method name="ExampleWithSplits" startTime=".*"\> | |||
| // CHECK: \<assertionBatch number="1" iteration="0" startTime=".*"\> | |||
| // CHECK: \<assertion file="xml.bpl" line="25" column="3" /\> | |||
| // CHECK: \<conclusion duration=".*" outcome="valid" resourceCount=".*" /\> | |||
| // CHECK: \<conclusion duration=".*" outcome="valid" resourceCount=".*" smtInputSize="601" /\> | |||
There was a problem hiding this comment.
It looks like these values need updating again.
|
Currently sometimes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Record the SMT input string size for each split, which can be used to detect regressions in encoding performance
Testing
Updated existing test xml.bpl