Parse /proc/self/maps when the dynamic loader doesn't provide enough info #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provide enough information about a module's location
bombela
requested changes
Jun 28, 2018
| @@ -1676,72 +1676,91 @@ class TraceResolverLinuxImpl<trace_resolver_tag::libdwarf>: | |||
| // Let's try to find from which loaded object it comes from. | |||
| // The loaded object can be yourself btw. | |||
|
|
|||
| Dl_info symbol_info; | |||
| Dl_info symbol_info = { NULL, NULL, NULL, NULL }; | |||
There was a problem hiding this comment.
memset/bzero instead? in the worse case, use nullptr
| @@ -1872,9 +1891,29 @@ class TraceResolverLinuxImpl<trace_resolver_tag::libdwarf>: | |||
| } | |||
| }; | |||
|
|
|||
| typedef std::map<Dwarf_Off, die_cache_entry> die_cache_t; | |||
| struct proc_maps_entry { | |||
There was a problem hiding this comment.
not a big deal, but maybe cleanup the indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the dynamic loader doesn't provide enough information about a module's location, use /proc/self/maps to figure out the absolute file path and loading address.
The contents of the file are kept cached as they might be useful to resolve other traces.