Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix legacy transactions #11

Open
wants to merge 2 commits into
base: optimism
Choose a base branch
from
Open

Fix legacy transactions #11

wants to merge 2 commits into from
+34 −0

Conversation

boyuan-chen
Copy link

In our legacy transaction receipt, we have a custom field called L2BobaFee. This fixes the issue of fetching the transaction receipts for legacy blocks.

jyellick
jyellick approved these changes Nov 26, 2024
View reviewed changes
Copy link

@jyellick jyellick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way we can add an automated test for this? Maybe on the boba repo integration test?

@boyuan-chen
Copy link
Author

Any way we can add an automated test for this? Maybe on the boba repo integration test?

It requires the old db, but I have added an unit test to cover it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmontour1306 mmontour1306 mmontour1306 approved these changes

@jyellick jyellick jyellick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boyuan-chen @jyellick @mmontour1306