Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace effects with react query callbacks #314

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Replace effects with react query callbacks #314

wants to merge 14 commits into from

Conversation

slavastartsev
Copy link
Contributor

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2e30539

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bob-mainnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 7:53pm
bob-pay ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 7:53pm
bob-sepolia ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 7:53pm
storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2024 7:53pm

@slavastartsev slavastartsev marked this pull request as ready for review November 18, 2024 22:06
slavastartsev
slavastartsev commented Nov 19, 2024
View reviewed changes
packages/ui/src/components/TokenInput/TokenInput.tsx
@@ -67,7 +68,9 @@ const TokenInput = forwardRef<HTMLInputElement, TokenInputProps>((props, ref): J
setValue(valueProp);
}, [valueProp]);
Copy link
Contributor Author

@slavastartsev slavastartsev Nov 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this useEffect to if like in NumberInput will fail existing tests

slavastartsev
slavastartsev commented Nov 20, 2024
View reviewed changes
apps/evm/src/app/[lang]/apps/components/HeroBanner/HeroBanner.tsx
objectFit: 'cover',
objectPosition: '50% 70%'
}}
/>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes
image

@danielsimao
Copy link
Collaborator

@slavastartsev I read through the PR, but I would like to give it another go but with the latest updates. Sorry for the delay.

@slavastartsev
Copy link
Contributor Author

@slavastartsev I read through the PR, but I would like to give it another go but with the latest updates. Sorry for the delay.

Will merge it with the latest changes from master branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsimao danielsimao Awaiting requested review from danielsimao

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavastartsev @danielsimao