consensus/parlia: support recovery when snapshot of parlia gone in disk #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
force-pushed
the
support_recovery_when_snapshot_gone
branch
from
5c94a76
to
34a8d37
Compare
buddh0
force-pushed
the
support_recovery_when_snapshot_gone
branch
from
34a8d37
to
6f0c635
Compare
zlacfzy
reviewed
Jul 16, 2024
zlacfzy
previously approved these changes
Jul 17, 2024
zlacfzy
previously approved these changes
Jul 17, 2024
MatusKysel
reviewed
Jul 17, 2024
blxdyx
approved these changes
Jul 18, 2024
zlacfzy
previously approved these changes
Jul 18, 2024
galaio
reviewed
Jul 18, 2024
MatusKysel
previously approved these changes
Jul 18, 2024
zlacfzy
previously approved these changes
Jul 18, 2024
galaio
previously approved these changes
Jul 18, 2024
MatusKysel
previously approved these changes
Jul 18, 2024
buddh0
dismissed stale reviews from MatusKysel, galaio, and zlacfzy
via
4954a0e
buddh0
force-pushed
the
support_recovery_when_snapshot_gone
branch
from
1c745cd
to
4954a0e
Compare
buddh0
force-pushed
the
support_recovery_when_snapshot_gone
branch
from
4954a0e
to
16f28bd
Compare
zlacfzy
approved these changes
Aug 8, 2024
zzzckck
approved these changes
Aug 8, 2024
|
it only helps when parlia.snapshot is removed by accident, which is unlikely to happen, so it is not a big issue, but an enhancement in this corner case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
consensus/parlia: support recovery when snapshot of parlia gone in disk
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: