Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added team data #299

Merged
merged 16 commits into from
Oct 29, 2024
Merged

Added team data #299

merged 16 commits into from
Oct 29, 2024

Conversation

styrix560
Copy link
Collaborator

closes #19

@styrix560 styrix560 self-assigned this Oct 28, 2024
src/pages/[lang]/our-team.astro Show resolved Hide resolved
src/components/team/PersonImage.tsx Outdated Show resolved Hide resolved
src/assets/data/team.json Outdated Show resolved Hide resolved
src/assets/data/team.json Outdated Show resolved Hide resolved
src/assets/data/team.json Outdated Show resolved Hide resolved
src/assets/data/team.json Show resolved Hide resolved
src/assets/data/team.json Outdated Show resolved Hide resolved
src/assets/data/team.json Outdated Show resolved Hide resolved
src/assets/data/team.json Outdated Show resolved Hide resolved
src/components/team/Person.astro Outdated Show resolved Hide resolved
@styrix560
Copy link
Collaborator Author

What do you think about sorting by last names? for example something like:

name.split(" ").at(-1)

@JonasWanke
Copy link
Member

@styrix560 No strong preference about sorting by first vs. last name.

Can you please push your changes? :)

@styrix560
Copy link
Collaborator Author

@styrix560 No strong preference about sorting by first vs. last name.

Can you please push your changes? :)

Sorry ^^

src/assets/data/team.json Outdated Show resolved Hide resolved
src/assets/data/team.json Outdated Show resolved Hide resolved
src/components/team/PersonImage.tsx Outdated Show resolved Hide resolved
@styrix560
Copy link
Collaborator Author

I will also incorperate #302 for team.json

@styrix560 styrix560 merged commit a541fa7 into main Oct 29, 2024
2 checks passed
@styrix560 styrix560 deleted the team-page branch October 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Team page
2 participants