Arrayvec copy 2 #40
Closed
Arrayvec copy 2 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`RawArrayVec` does not concern itself with the dropping or non-dropping of elements when it goes out of scope.
|
@tbu- What do you think? This solves it without size expansion. I think I like the trait for code reuse better. |
|
This works too. I view it as a complication of just sharing the same struct, if the no-regressions thing is that important, we could also wait a cycle (or two?) until the no-drop-flags thing hits stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP continuation of #34
Using traits instead of data for reusing code