Add Batch functions for add, delete & synchronize products #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MrGekko What do you mean by "builds on the last commit" ? |
|
As you can see on: I did the branching on the commit: |
|
You could try it on 1.x, but I would recomment this branch: https://github.com/MrGekko/GoogleShoppingApi/tree/Mr.Gekko to test it (this includes the 2.0..) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on the batch functionality of the last commit and adds the delete and add product batching.
I only tested this with my other pull request in place for the google-api 2.0.
The performance increases about 300%.
And I can add/sync/delete about 1000 products effortlessly, with the other setup I could only add ~500 a time.
Havn't tested cron performance yet but it should go smoothly.