Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: finally remove the old ISO action (#22) #24

Merged
merged 1 commit into from
Mar 17, 2024

Conversation

xynydev
Copy link
Member

@xynydev xynydev commented Mar 17, 2024

No description provided.

@xynydev xynydev requested a review from fiftydinar as a code owner March 17, 2024 10:32
@xynydev xynydev linked an issue Mar 17, 2024 that may be closed by this pull request
Copy link
Collaborator

@fiftydinar fiftydinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP my old friend.

@fiftydinar fiftydinar merged commit 8ef6697 into main Mar 17, 2024
2 checks passed
@fiftydinar fiftydinar deleted the 22-chore-finally-remove-the-old-iso-action branch March 17, 2024 11:17
@arteeh
Copy link

arteeh commented Mar 18, 2024

What is the reason for doing this?

I don't want to manually create ISOs. I like how my custom ISO can easily be grabbed from my Releases page.

I still have release-iso.yml in my repo. Can I keep it running or will it stop working eventually?

@fiftydinar
Copy link
Collaborator

fiftydinar commented Mar 18, 2024

What is the reason for doing this?

I don't want to manually create ISOs. I like how my custom ISO can easily be grabbed from my Releases page.

I still have release-iso.yml in my repo. Can I keep it running or will it stop working eventually?

The reason for doing this is that isogenerator-old repo is depreciated by the Universal Blue team, which made it possible to build online ISOs & release them in GitHub releases.

Their reasoning for depreciation is unreliable handling of online images by the installer itself. It would often error-out & refuse to install for some users, even if they had good internet connection. It lacked proper info on why the installer failed, it lacked progress info on how much of the image is downloaded, option to retry online-install if failed etc.
I personally never had any issue with it, but I understand & agree with their decision.

I understand your reasoning & I also miss that benefit.

You can keep running the old online ISO action & it will work just fine.
The only thing that can possibly change in the far-future, which would break things, is stuff related to Secure Boot support with enrolling security key. F.e. if Universal Blue decides that they want to re-new the secure key, than enrolling the current key will not work & SecureBoot system would fail to boot.

New isogenerator allows more customization regarding this to downstream users like us, which would prevent issues like these. It also has the benefit of ISOs working with Ventoy, auto-language + region detection & no need to manually rebase to signed image afterwards.

Unfortunately, it currently doesn't support generating online ISOs & it doesn't support upload to GitHub releases due to file-size limit.
Some users have an idea of making the GitHub action where offline ISOs could automatically build & upload to Archive.org in scheduled time. But that's just an idea, which is not yet realized.

New isogenerator is based on this upstream repo, which Universal Blue can potentially use in the future instead of their forked one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: finally remove the old ISO action
3 participants