Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(recipe): Allow changing the public key used to verify base image #218

Open
wants to merge 2 commits into
base: template
Choose a base branch
from

Conversation

EyeCantCU
Copy link
Contributor

Adds an entry to recipe.yml enabling users to define their own public keys for the 'verify' action

@EyeCantCU EyeCantCU requested a review from castrojo as a code owner January 3, 2024 22:01
@xynydev
Copy link
Member

xynydev commented Jan 9, 2024

This feature desperately needs documentation somewhere. I'm not sure about a new top-level recipe entry, though... I mean, I can see the point, I'm just hesitant. But idk if this is still the better alternative to recommending the editing of build.yml.

Ok, how about making this an optional parameter, which uses the ublue key if nonexistant? So that people who ignore changes when doing manual merges to the recipe won't get a broken build. Then include this option in the recipe commented-out with a short explanation. This should also be added to the docs here: https://github.com/ublue-os/startingpoint/tree/template/config#basic-options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants