feat: add support for nested modules #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
marked as ready as i'm pretty positive builds work now, might want to add documentation on this as well, the current default setup is to derive the modules from modules.yml, but feel free to change that. I just did it to test out the nesting functionality |
|
Looks good and really clean. I would leave out the modules.yml though and just keep the inline modules. This also needs docs, but I can do that if you're more comfortable with that. |
|
ok moved back to the older recipe.yml configuration, also corrected a typo |
xynydev
approved these changes
Sep 19, 2023
vietchinh
pushed a commit
to vietchinh/ulightblue
that referenced
this pull request
Sep 19, 2023
* feat: add support for nested modules * chore: test out module nesting * fix: made build function * revert: move back to old recipe.yml configuration * fix: formatting in recipe.yml * style: add newline between modules
tulilirockz
pushed a commit
to tulilirockz/Malachite
that referenced
this pull request
Sep 21, 2023
* feat: add support for nested modules * chore: test out module nesting * fix: made build function * revert: move back to old recipe.yml configuration * fix: formatting in recipe.yml * style: add newline between modules
tulilirockz
pushed a commit
to tulilirockz/Malachite
that referenced
this pull request
Sep 21, 2023
* feat: add support for nested modules * chore: test out module nesting * fix: made build function * revert: move back to old recipe.yml configuration * fix: formatting in recipe.yml * style: add newline between modules
RoyalOughtness
referenced
this pull request
in secureblue/secureblue
Sep 21, 2023
* feat: add support for nested modules * chore: test out module nesting * fix: made build function * revert: move back to old recipe.yml configuration * fix: formatting in recipe.yml * style: add newline between modules
RoyalOughtness
referenced
this pull request
in secureblue/secureblue
Nov 27, 2023
* feat: add support for nested modules * chore: test out module nesting * fix: made build function * revert: move back to old recipe.yml configuration * fix: formatting in recipe.yml * style: add newline between modules
RoyalOughtness
referenced
this pull request
in secureblue/secureblue
Nov 27, 2023
* feat: add support for nested modules * chore: test out module nesting * fix: made build function * revert: move back to old recipe.yml configuration * fix: formatting in recipe.yml * style: add newline between modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fingers crossed this actually builds