Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to textual 0.88.0 #698

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Adapt to textual 0.88.0 #698

merged 1 commit into from
Nov 29, 2024

Conversation

pablogsal
Copy link
Member

The new textual release has some changes:

  • There are some changes that we need to do to get the rendered version
    of some textual objects as now render() returns RichVisual instances
  • Textual has a new theme so we need to regenerate our snapshots.
  • There is something going on with horizontal scroll bars. We have
    opened Horizontal scroll bar disappeared in 0.87.1 Textualize/textual#5284 but looks
    like this may be expected.

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

@pablogsal
Copy link
Member Author

Note that Textualize/textual#5284 may still be a bug

@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (beea5cd) to head (46248f0).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #698      +/-   ##
==========================================
- Coverage   92.93%   92.87%   -0.07%     
==========================================
  Files          95       95              
  Lines       11655    11655              
  Branches      406      406              
==========================================
- Hits        10832    10824       -8     
- Misses        823      831       +8     
Flag Coverage Δ
cpp 92.87% <100.00%> (-0.07%) ⬇️
python_and_cython 92.87% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pablogsal pablogsal requested a review from Copilot November 27, 2024 00:33

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 23 out of 23 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

tests/unit/test_tui_reporter.py:144

  • Ensure that the change from widget.render() to widget.renderable is covered by tests to verify the behavior remains correct.
rprint(widget.renderable, file=output)
@@ -5,7 +5,7 @@
from packaging import version

SNAPSHOT_MINIMUM_VERSIONS = {
"textual": "0.81",
"textual": "0.87.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update this to whatever version their next release is (either 0.88.0 or 0.87.2), since we know these tests don't pass with 0.87.1 (they need a release that contains Textualize/textual#5296 to pass)

Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to land as soon as Textual cuts a release that contains Textualize/textual#5296

Once they do, we should bump our SNAPSHOT_MINIMUM_VERSIONS to match their new version number, and then this PR should pass and we can rebase the others that have gotten blocked behind the failing CI.

@godlygeek godlygeek changed the title Adapt to textual 0.87.1 Adapt to textual 0.88.0 Nov 29, 2024
The new Textual release has some changes:

* We need to change how our tests get the rendered version of some
  Textual objects as now `render()` returns `RichVisual` instances.
* Textual has a new theme so we need to regenerate our snapshots.

Signed-off-by: Matt Wozniski <[email protected]>
@godlygeek godlygeek enabled auto-merge (rebase) November 29, 2024 20:12
@godlygeek godlygeek merged commit aa1b452 into bloomberg:main Nov 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants