Update our vendored libbacktrace #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
regenerate
branch
2 times, most recently
from
e586655 to
e458592
Compare
|
Closes: #647 |
This picks up bug fixes for upstream that we are already patching as well as many others that we don't account for. The patches need to be regenerated due to multiple conflicts as well as the usage of the exposed interfaces in our memray code. Signed-off-by: Pablo Galindo <[email protected]>
Updated to commit 7e2b7da3d6568d2e4e78658f22e701746a48d7e1 Signed-off-by: Pablo Galindo <[email protected]>
Seems that the comparison tests now are in different files per individual test instead of a single file per test file. Signed-off-by: Pablo Galindo <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 92.55% 93.01% +0.46%
==========================================
Files 91 94 +3
Lines 11304 11420 +116
Branches 1581 2094 +513
==========================================
+ Hits 10462 10622 +160
+ Misses 837 798 -39
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The last version of `pytest-textual-snapshot` to support Python 3.7 uses a different naming convention for its snapshot results than the current version. Because of this, once our test suite is updated to use the naming convention required by the latest version, the old version sees all of these new snapshot result files as extra junk not being used by the test suite, and believes they should be removed. Hack around this by programmatically enabling Syrupy's `--snapshot-warn-unused` option for Python 3.7. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to commit 7e2b7da3d6568d2e4e78658f22e701746a48d7e1
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.