Update tests to support Textual 0.71 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
godlygeek
commented
Jul 2, 2024
•
godlygeek
commented
- Work around a Textual deadlock in our tests. There's a deadlock on shutdown when the pilot exits before the message pump has quiesced, but it doesn't occur when we wait for the message pump to become idle.
- Update our tests' Textual snapshots. The latest version of Textual uses a new SVG generation algorithm that results in some slight differences compared to the old algorithm's output, but should be more stable going forward. Additionally, the two trailing spaces removed by the previous commit show up as differences in these snapshots.
- Avoid extra trailing spaces on node in the tree reporter tree. If trailing spaces are included, they are highlighted with an orange background when the line is selected.
godlygeek
changed the title
pablogsal
approved these changes
Jul 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 92.55% 93.00% +0.45%
==========================================
Files 91 94 +3
Lines 11304 11415 +111
Branches 1581 2092 +511
==========================================
+ Hits 10462 10617 +155
+ Misses 837 798 -39
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Deadlock reported at Textualize/textual#4699 |
There's a deadlock on shutdown when the pilot exits before the message pump has quiesced, but it doesn't occur when we wait for the message pump to become idle. Signed-off-by: Matt Wozniski <[email protected]>
If trailing spaces are included, they are highlighted with an orange background when the line is selected. Signed-off-by: Matt Wozniski <[email protected]>
The latest version of Textual uses a new SVG generation algorithm that results in some slight differences compared to the old algorithm's output, but should be more stable going forward. Additionally, the two trailing spaces removed by the previous commit show up as differences in these snapshots. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
update_to_latest_textual
branch
from
dce663a to
b30be4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.