Reintroduce debuginfod deadlock workaround #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While switching from referencing the system debuginfod client library to vendoring our own copy of it, I removed a hack that turns out to still be required for some libc versions, because I incorrectly thought it only applied to the case when debuginfod was being loaded with `dlopen`. Signed-off-by: Matt Wozniski <[email protected]>
See changelog for more details. Signed-off-by: Matt Wozniski <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #635 +/- ##
==========================================
+ Coverage 92.55% 93.02% +0.47%
==========================================
Files 91 94 +3
Lines 11304 11412 +108
Branches 1581 2089 +508
==========================================
+ Hits 10462 10616 +154
+ Misses 837 796 -41
+ Partials 5 0 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ZeroIntensity confirmed for me that the wheels built by this CI run do in fact fix #634. |
pablogsal
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While switching from referencing the system debuginfod client library to vendoring our own copy of it, I removed a hack that turns out to still be required for some libc versions, because I incorrectly thought it only applied to the case when debuginfod was being loaded with
dlopen.Closes #634