Fix timezone on stats modal #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitimm144
force-pushed
the
fix-timezone-on-stats-modal
branch
from
48d9238 to
5043bef
Compare
sarahmonod
approved these changes
May 21, 2024
1 task
godlygeek
force-pushed
the
fix-timezone-on-stats-modal
branch
2 times, most recently
from
3a8c075 to
e41f588
Compare
godlygeek
approved these changes
May 26, 2024
There was a problem hiding this comment.
This was only half the fix, but I've pushed a separate commit with the other half. In addition to having making the HTML reporters localize the date/time when the page is loaded, we also need to embed the original time zone in the report. Previously we were embedding a non-localized time stamp, which didn't contain enough information to properly localize it to a different time zone.
After adding that commit (and a news entry), this looks good to me!
Thank you for the contribution!
godlygeek
force-pushed
the
fix-timezone-on-stats-modal
branch
from
e41f588 to
8702f42
Compare
Signed-off-by: Victor dos Reis Avelino da Silva <[email protected]>
Prior to this we were including a naive datetime, which did not include enough information to allow it to be localized if a report was viewed on a machine with a different time zone than the one it was generated on. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
fix-timezone-on-stats-modal
branch
from
8702f42 to
e48dc2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #591
Describe your changes
Used vanilla javascritpt to format the datetime on stats table