Limit the number of memory records reported #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
blegd
branch
2 times, most recently
from
03ddecf to
9243e82
Compare
pablogsal
force-pushed
the
blegd
branch
4 times, most recently
from
38d1bde to
e56b11c
Compare
godlygeek
requested changes
Nov 7, 2023
pablogsal
force-pushed
the
blegd
branch
2 times, most recently
from
8cd7bfa to
fdb1abf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 92.16% 92.16%
=======================================
Files 91 91
Lines 10872 10898 +26
Branches 1499 1507 +8
=======================================
+ Hits 10020 10044 +24
- Misses 849 851 +2
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
godlygeek
requested changes
Nov 9, 2023
For very big files, the generated reporters will hung when trying to process all of the memory records produced. This happens quite a lot in flamegraphs produced from very big files, where the browser cannot display the ploy with millions of points. To help here, add a new parameter to the FileReader class that limits the number of memory records (and therefore temporal snapshots) stored and reported. This should not affect most regular capture files but will help with the very big ones. Signed-off-by: Pablo Galindo <[email protected]> Co-authored-by: Matt Wozniski <[email protected]> Signed-off-by: Pablo Galindo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.