Do not patch PLT stubs for MallocStackLogging in MacOS #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MacOS has some memory interposition libraries that can make us crash (via stackoverflow when initializing TLS variables) if we patch them. This is because these libraries interact in a way we cannot avoid with libdyld, which in turn sets the TLS on first init.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
==========================================
+ Coverage 91.97% 92.15% +0.18%
==========================================
Files 91 91
Lines 10803 10849 +46
Branches 1485 1498 +13
==========================================
+ Hits 9936 9998 +62
+ Misses 865 849 -16
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lkollar
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS has some memory interposition libraries that can make us crash
(via stackoverflow when initializing TLS variables) if we patch them.
This is because these libraries interact in a way we cannot avoid with
libdyld, which in turn sets the TLS on first init.
Closes: #476