Rename flamegraph "Invert" button #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
rename_invert_button
branch
from
5f06c01 to
b24c426
Compare
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #456 +/- ##
=======================================
Coverage 91.84% 91.85%
=======================================
Files 90 90
Lines 10767 10767
Branches 1474 1474
=======================================
+ Hits 9889 9890 +1
+ Misses 876 875 -1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
godlygeek
force-pushed
the
rename_invert_button
branch
2 times, most recently
from
ff3c545 to
541a8fa
Compare
We've adding a `--inverted` mode to `memray flamegraph` causing stacks to be added to the flame graph in reverse order, so that the children of the root are functions that performed allocations and the leaves are thread entry points. Because of this change, we need a different name for the "Invert" button that flips the entire flame graph upside down. This commit introduces a new toggle button for switching between our default "icicle graph" view (with the root at the top and allocations dangling from it) and the traditional "flame graph" view (with the root at the bottom and allocations rising up from it). The toggle button also gives a visual indication of what mode you're in. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
rename_invert_button
branch
from
541a8fa to
7be5c45
Compare
pablogsal
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've adding a
--invertedmode tomemray flamegraphcausing stacks to be added to the flame graph in reverse order, so that the children of the root are functions that performed allocations and the leaves are thread entry points. Because of this change, we need a different name for the "Invert" button that flips the entire flame graph upside down.This commit introduces a new toggle button for switching between our default "icicle graph" view (with the root at the top and allocations dangling from it) and the traditional "flame graph" view (with the root at the bottom and allocations rising up from it). The toggle button also gives a visual indication of what mode you're in.