Temporal inverted flame graph #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
reviewed
Sep 7, 2023
| @@ -144,6 +144,7 @@ <h5 class="modal-title" id="helpModalLabel">How to interpret {{ kind }} reports< | |||
| const merge_threads = {{ merge_threads|tojson }}; | |||
| const memory_records = {{ memory_records|tojson }}; | |||
| const inverted = {{ inverted|tojson }}; | |||
| const temporal = packed_data["high_water_mark_by_snapshot"] != null; | |||
There was a problem hiding this comment.
This isn't fully correct - --temporal --leaks flamegraphs don't have high_water_mark_by_snapshot. Let's instead check:
Suggested change
| const temporal = packed_data["high_water_mark_by_snapshot"] != null; | |
| const temporal = packed_data.intervals != null; |
That condition is true both with and without --leaks
godlygeek
reviewed
Sep 7, 2023
| const { strings, nodes, unique_threads } = packedData; | ||
|
|
||
| function generateNodeObjects(packedData) { | ||
| const { strings, nodes } = packedData; |
There was a problem hiding this comment.
Since we only need 2 things, let's just have the caller pass two parameters, instead of forcing them to pass an object that we can unpack here
Comment on lines
89
to
92
| if (!node_objects) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
Hm, this check is new - why do we need it?
ivonastojanovic
force-pushed
the
temporal_inverted_flame_graph
branch
from
e7d924d to
e65c1e9
Compare
Allow `memray flamegraph` to support `--temporal` and `--inverted` at the same time. Signed-off-by: Ivona Stojanovic <[email protected]>
godlygeek
force-pushed
the
temporal_inverted_flame_graph
branch
from
e65c1e9 to
48dad0c
Compare
godlygeek
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number of the reported bug or feature request: #
Describe your changes
A clear and concise description of the changes you have made.
Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.
Additional context
Add any other context about your contribution here.