Skip to content

Commit

Permalink
ci: Install libdebuginfod for all workflows
Browse files Browse the repository at this point in the history
Now that we've introduced a build-time dependency on `libdebuginfod` on
Linux, we need to ensure it's installed in every environment that we
perform an install in.

For testing on Alpine in particular, though, set an environment variable
to skip it, since Alpine doesn't ship `libdebuginfod` and we don't want
to have to build it from source just for the sake of this test.

Signed-off-by: Matt Wozniski <[email protected]>
  • Loading branch information
godlygeek committed May 6, 2024
1 parent 1908e65 commit c2ef910
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Set up dependencies
run: |
sudo apt-get update
sudo apt-get install -qy libunwind-dev liblz4-dev pkg-config npm gdb lldb lcov
sudo apt-get install -qy libdebuginfod-dev libunwind-dev liblz4-dev pkg-config npm gdb lldb lcov
- name: Create virtual environment
run: |
python3 -m venv venv
Expand Down Expand Up @@ -98,6 +98,7 @@ jobs:
CYTHON_TEST_MACROS: 1
PYTHON: /venv/bin/python
GENHTMLOPTS: "--ignore-errors inconsistent"
NO_MEMRAY_DEBUGINFOD_SUPPORT: 1
run: |
make dev-install pycoverage
Expand All @@ -119,7 +120,7 @@ jobs:
- name: Set up dependencies
run: |
sudo apt-get update
sudo apt-get install -qy clang-format npm libunwind-dev liblz4-dev pkg-config
sudo apt-get install -qy clang-format npm libdebuginfod-dev libunwind-dev liblz4-dev pkg-config
- name: Install Python dependencies
run: |
python3 -m pip install -r requirements-extra.txt
Expand All @@ -146,7 +147,7 @@ jobs:
- name: Set up dependencies
run: |
sudo apt-get update
sudo apt-get install -qy libunwind-dev liblz4-dev pkg-config npm valgrind
sudo apt-get install -qy libdebuginfod-dev libunwind-dev liblz4-dev pkg-config npm valgrind
- name: Install Python dependencies and package
run: |
python3 -m pip install --upgrade pip
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ jobs:
sudo apt-get update
sudo apt-get install -qy \
pkg-config \
libdebuginfod-dev \
libunwind-dev \
liblz4-dev \
gdb \
Expand Down

0 comments on commit c2ef910

Please sign in to comment.