Update S3 Access Permissions for new AWS Policy

[jeffmaher]

Changes

When I was running the initial setup Terraform for staging, it seems like there was a change in the default configuration of S3 buckets and the ACL setup config is no longer valid. This relates to a change apparently arrived in April 2023 (this month) which disables ACLs by default.

For the state setup, it's fine to remove the ACL since the new default is to block public access which is the desired config.

For the main S3 storage for the static site, it seems there are still issues in Terraform regarding the policy change that are still be added. See the following Terraform issues:

• Notice: S3 - Changes to Defaults (Block Public Access and ACL's) hashicorp/terraform-provider-aws#28353
• feat: Updated S3 Bucket Block Public Access and ACL(Object Ownership) defaults to work since April 2023 terraform-aws-modules/terraform-aws-s3-bucket#226
• Error creating S3 bucket ACL for $BUCKET: AccessControlListNotSupported: The bucket does not allow ACLs terraform-aws-modules/terraform-aws-s3-bucket#223 (comment)

Screenshots

This is what was happening.

For the state setup:

After the fix, this worked:

For the main deployment setup:

After the fix, this worked:

Checklist

• if changes filter/search functionality, adds or updates unit tests
• if adds a new page, adds accessibility tests
• if adds a new page or new interaction, adds e2e test
• if adds a new page or new interaction, sends google analytics events and updates GA doc
• if changes filter functionality, updates filters doc

[jeffmaher]

Added a new configuration for state storage and the static site S3 buckets. I linked to a few Terraform GitHub Issues in the main description of this Issue. This new configuration is a workaround until these issues are solved in Terraform and the AWS Provider.

One known issue is that there is a race condition in apply the storage_policy resource. If it fails at first, wait 5 minutes and then re-apply after the failure. The third linked issue in the description uses a timer to effectively build in this delay and that might be considered too.