Skip to content

Commit

Permalink
github: preprare CI for uploading of metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
kar committed Oct 30, 2024
1 parent 5226f0d commit c720813
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 14 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/family.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Blokada Family for iOS (CI)
name: six-ios family

on:
workflow_dispatch:
Expand Down
18 changes: 6 additions & 12 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Blokada 6 for iOS (CI)
name: six-ios v6

on:
workflow_dispatch:
Expand All @@ -16,17 +16,6 @@ jobs:
with:
submodules: recursive

- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: '1.21' # Replace with the Go version you need

- name: Verify Go installation
run: |
go version
echo $PATH
- name: Get Flutter
uses: subosito/flutter-action@v2
with:
Expand All @@ -45,6 +34,11 @@ jobs:
run: |
git config --global url."https://${{ secrets.GIT_TOKEN }}@github.com/".insteadOf "[email protected]:"
make sixcommon
- name: Set up Go
uses: actions/setup-go@v4
with:
go-version: '1.21' # Replace with the Go version you need

- name: Set up ruby env
uses: ruby/setup-ruby@v1
Expand Down
3 changes: 3 additions & 0 deletions fastlane/Deliverfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# The Deliverfile allows you to store various App Store Connect metadata
# For more information, check out the docs
# https://docs.fastlane.tools/actions/deliver/
1 change: 0 additions & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,6 @@ lane :upload_release do
deliver(
api_key: api_key,
skip_screenshots: true,
skip_metadata: true,
skip_app_version_update: true,
force: true, # skips verification of HTML preview file (since this will be run from a CI machine)
run_precheck_before_submit: false # not supported through ASC API yet
Expand Down
30 changes: 30 additions & 0 deletions fastlane/screenshots/README.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
## Screenshots Naming Rules

Put all screenshots you want to use inside the folder of its language (e.g. `en-US`).
The device type will automatically be recognized using the image resolution.

The screenshots can be named whatever you want, but keep in mind they are sorted
alphabetically, in a human-friendly way. See https://github.com/fastlane/fastlane/pull/18200 for more details.

### Exceptions

#### iPad Pro (3rd Gen) 12.9"

Since iPad Pro (3rd Gen) 12.9" and iPad Pro (2nd Gen) 12.9" have the same image
resolution, screenshots of the iPad Pro (3rd gen) 12.9" must contain either the
string `iPad Pro (12.9-inch) (3rd generation)`, `IPAD_PRO_3GEN_129`, or `ipadPro129`
(App Store Connect's internal naming of the display family for the 3rd generation iPad Pro)
in its filename to be assigned the correct display family and to be uploaded to
the correct screenshot slot in your app's metadata.

### Other Platforms

#### Apple TV

Apple TV screenshots should be stored in a subdirectory named `appleTV` with language
folders inside of it.

#### iMessage

iMessage screenshots, like the Apple TV ones, should also be stored in a subdirectory
named `iMessage`, with language folders inside of it.

0 comments on commit c720813

Please sign in to comment.