Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts db #416

Draft
wants to merge 11 commits into
base: 2_0_16
Choose a base branch
from
Draft

Accounts db #416

wants to merge 11 commits into from

Conversation

mango-dee
Copy link
Contributor

Requires 2_0_16 to be landed first

@mango-dee mango-dee force-pushed the 2_0_16 branch 6 times, most recently from c60f0b4 to 23ba2a0 Compare December 9, 2024 03:40
@grooviegermanikus
Copy link
Collaborator

how is this related to Pratiks crate solana-lite-account-manager ?


#[async_trait]
impl AccountStorageInterface for AccountsDb {
async fn update_account(&self, account_data: AccountData, _commitment: Commitment) -> bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: we actually do not want to have and support commitments other than PROCESSED as this will push complexity of buffering and slot commitment handling to yellowstone-grpc

}
}

async fn process_slot_data(&self, slot: Slot, commitment: Commitment) -> Vec<AccountData> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pratik promised to do a proper tested implementation in solana-lite-account-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants