Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Refactor emit swap canceled to use msg.sender to spend less gas #189

Merged

Conversation

0xjoaovpsantos
Copy link
Contributor

@0xjoaovpsantos 0xjoaovpsantos commented Feb 2, 2024

Refactor this suggestion: #188 (comment)

image

@0xjoaovpsantos 0xjoaovpsantos changed the title refactor: switch to emit swap canceled with msg.sender #186 Suggestion: Refactor emit swap canceled to use msg.sender to spend less gas Feb 2, 2024
Copy link
Contributor

@0xneves 0xneves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xjoaovpsantos Thank you so much!🙌

@0xneves 0xneves merged commit 02bb801 into blockful-io:main Feb 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants