Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-5559 with getDeferralHandler #245

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Dec 4, 2024

EIP-5559 with WriteParams

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

It introduces the writeParams calls according to #241. It is basically a view call done before the actual transaction to gather all the important information for the offchain call.

This is how the interfaces are currently implemented. Ideally, the WildcardWriting interface, which only has the writeParams call, would get implemented within the IWriteDeferrral interface proposed by the EIP-5559.

image

Disclaimer:

The fixing of tests lead to a small refactor where the metadata tests got moved to their own file to simplify test logic.

Related Issue

#241

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Additional Notes

This might lead to an improvement to the EIP-5559.

@pikonha pikonha added the enhancement New feature or request label Dec 4, 2024
@pikonha pikonha added this to the Offchain Resolver ENSIP milestone Dec 4, 2024
@pikonha pikonha self-assigned this Dec 4, 2024
@pikonha pikonha linked an issue Dec 4, 2024 that may be closed by this pull request
@pikonha pikonha force-pushed the 241-l2-support-writeparams branch from ca9dc0b to 414862b Compare December 4, 2024 10:33
packages/client/src/write.ts Outdated Show resolved Hide resolved
@pikonha pikonha changed the title EIP-5559 with WriteParams EIP-5559 with getDeferralHandler Dec 9, 2024
packages/client/src/write.ts Show resolved Hide resolved
packages/client/src/write.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Support getDeferralHandler on the EIP-5559
2 participants