Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard Writing based on IWriteDeferral w/ view call #239

Open
wants to merge 10 commits into
base: 241-l2-support-writeparams
Choose a base branch
from

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Nov 7, 2024

Wildcard Writing v0.2

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

The feedback gathered from the community has been applied to our interface resulting in some minor changes:

  • Removal of the OffchainMulticallable
  • Creation of the RegisterRequest struct to avoid stack too deep errors
  • Addition of the token (according to the EIP-7528) and available properties to the RegisterParams struct
  • Addition of the OffchainTransferrable interface

Related Issue

#237
#233
#231

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Additional Notes

@pikonha pikonha added the enhancement New feature or request label Nov 7, 2024
@pikonha pikonha added this to the Offchain Resolver ENSIP milestone Nov 7, 2024
@pikonha pikonha self-assigned this Nov 7, 2024
@pikonha pikonha changed the title Wildcard Writing v0.2 Wildcard Writing break interfaces Dec 5, 2024
Copy link
Member

@LeonardoVieira1630 LeonardoVieira1630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Lucas,

Great work on the pull request! I've added a few comments, and my review was done focusing mainly on the smart contract patterns and quality. Since I currently have limited context about the ongoing work in the EAS team, some business rules or user flows might not have been fully captured in my review. Let me know if there’s anything specific you'd like me to take a closer look at!

Cheers!

packages/contracts/src/DatabaseResolver.sol Outdated Show resolved Hide resolved
@pikonha pikonha force-pushed the wildcard-writing-v02 branch from a2b31be to 431766c Compare December 9, 2024 09:30
@pikonha pikonha changed the base branch from main to 241-l2-support-writeparams December 9, 2024 09:30
@pikonha pikonha changed the title Wildcard Writing break interfaces Wildcard Writing based on IWriteDeferral w/ view call Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants