-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard Writing based on IWriteDeferral w/ view call #239
base: 241-l2-support-writeparams
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Lucas,
Great work on the pull request! I've added a few comments, and my review was done focusing mainly on the smart contract patterns and quality. Since I currently have limited context about the ongoing work in the EAS team, some business rules or user flows might not have been fully captured in my review. Let me know if there’s anything specific you'd like me to take a closer look at!
Cheers!
a2b31be
to
431766c
Compare
Wildcard Writing v0.2
All Submissions:
Description
The feedback gathered from the community has been applied to our interface resulting in some minor changes:
OffchainMulticallable
RegisterRequest
struct to avoidstack too deep
errorstoken
(according to the EIP-7528) andavailable
properties to theRegisterParams
structOffchainTransferrable
interfaceRelated Issue
#237
#233
#231
Changes
Changes to Core Features:
Additional Notes