Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mainnet Deploy fixes #116

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Mainnet Deploy fixes #116

merged 4 commits into from
Jun 17, 2024

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Jun 13, 2024

Mainnet deploy fixes

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

  • setAddr and addr by coin
  • ttl as seconds

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@pikonha pikonha marked this pull request as ready for review June 13, 2024 12:46
This was referenced Jun 14, 2024
Closed
Closed
@pikonha pikonha self-assigned this Jun 14, 2024
@pikonha pikonha added enhancement New feature or request bug Something isn't working labels Jun 14, 2024
@pikonha pikonha merged commit f0493db into main Jun 17, 2024
1 check passed
@pikonha pikonha deleted the mainnet-deploy branch June 17, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextnetto alextnetto Awaiting requested review from alextnetto alextnetto is a code owner

@LeonardoVieira1630 LeonardoVieira1630 Awaiting requested review from LeonardoVieira1630 LeonardoVieira1630 is a code owner

Assignees

@pikonha pikonha

Labels
bug Something isn't working enhancement New feature or request
Projects
ENS
Status: ✅ Done
Milestone
Implement reading flow from layer 2
Development

Successfully merging this pull request may close these issues.
1 participant
@pikonha