Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register domain Arbitrum L1 #109

Merged
merged 7 commits into from
Jun 12, 2024
Merged

Register domain Arbitrum L1 #109

merged 7 commits into from
Jun 12, 2024

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Jun 10, 2024

Register domain Arbitrum L1

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Fix the domain registration on L1 Resolver:

  • fix register domain that was setting the parent namehash as the target
  • taking ENS ownership in consideration when registering a new domain

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

@pikonha pikonha self-assigned this Jun 10, 2024
@pikonha pikonha added the enhancement New feature or request label Jun 10, 2024
@pikonha pikonha marked this pull request as ready for review June 10, 2024 14:52
@LeonardoVieira1630 LeonardoVieira1630 merged commit f9a9abb into main Jun 12, 2024
1 check passed
@LeonardoVieira1630 LeonardoVieira1630 deleted the multichain-deploy branch June 12, 2024 14:12
@pikonha pikonha restored the multichain-deploy branch June 25, 2024 12:50
@pikonha pikonha deleted the multichain-deploy branch August 22, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants