Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1 offchain register domain #107

Merged
merged 24 commits into from
Jun 7, 2024
Merged

L1 offchain register domain #107

merged 24 commits into from
Jun 7, 2024

Conversation

pikonha
Copy link
Contributor

@pikonha pikonha commented Jun 4, 2024

L1 offchain register domain

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Description

Related Issue

Changes

  • New feature implementation
  • Bug fix
  • Code refactoring
  • Documentation update
  • Other (please specify)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully run tests with your changes locally?

Additional Notes

@pikonha pikonha added the enhancement New feature or request label Jun 4, 2024
@pikonha pikonha self-assigned this Jun 4, 2024
@pikonha pikonha marked this pull request as ready for review June 5, 2024 14:00
LeonardoVieira1630
LeonardoVieira1630 requested changes Jun 5, 2024
View reviewed changes
Copy link
Member

@LeonardoVieira1630 LeonardoVieira1630 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice pull request Pik. I also run the tests here and every thing is fine.

.vscode/launch.json Show resolved Hide resolved
foundry.toml Show resolved Hide resolved
packages/client/src/read.ts Show resolved Hide resolved
packages/client/src/write.ts Outdated Show resolved Hide resolved
packages/client/src/write.ts Outdated Show resolved Hide resolved
packages/client/src/write.ts Outdated Show resolved Hide resolved
packages/gateway/src/handlers/slots.ts Show resolved Hide resolved
Base automatically changed from feat#22-client-write-l2 to main June 6, 2024 14:54
@pikonha pikonha merged commit 17bc0b2 into main Jun 7, 2024
1 check passed
@pikonha pikonha deleted the feat#83/l1-offchain-register branch June 7, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonardoVieira1630 LeonardoVieira1630 LeonardoVieira1630 requested changes

@alextnetto alextnetto Awaiting requested review from alextnetto alextnetto is a code owner

Assignees

@pikonha pikonha

Labels
enhancement New feature or request
Projects
ENS
Status: ✅ Done
Milestone
Implement writing on a layer 2 protocol
Development

Successfully merging this pull request may close these issues.
2 participants
@pikonha @LeonardoVieira1630