[indexer_autoscaler_lambda] tune Lambda reserved concurrency instead of ESM concurrency #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akumar1214
requested review from
myronmarston and
BrianSigafoos-SQ
as code owners
akumar1214
force-pushed
the
akumar/autoscaler-tune-lambda-concurrency
branch
from
d6a04f1 to
303f029
Compare
…a instead of updating the concurrency on the ESM
akumar1214
force-pushed
the
akumar/autoscaler-tune-lambda-concurrency
branch
from
303f029 to
e032ddc
Compare
myronmarston
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we're hard limited to a maximum concurrency of 1000 on the event source mapping but not on the reserved concurrency on the Lambda itself, this updates the autoscaler to tune the reserved concurrency on the Lambda instead of the concurrency on the ESM.
This also adds a maximum concurrency value since now it's possible for the max to be over 1000, as set by the client.
How tested?