Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update site homepage #10

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Update site homepage #10

merged 4 commits into from
Oct 31, 2024

Conversation

BrianSigafoos-SQ
Copy link
Collaborator

@BrianSigafoos-SQ BrianSigafoos-SQ commented Oct 30, 2024

Adding some new content, that's still evolving:

  • Success Stories
  • Testimonials
  • Getting started page WIP

Copy link
Collaborator

@myronmarston myronmarston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -6,7 +6,7 @@ To build the site and documentation locally, run `bundle exec rake -T | grep sit

## CSS Styling

CSS Styling is powerd by [Tailwind CSS](https://tailwindcss.com/) via the `package.json` script: `npm run build:css`.
CSS Styling is powered by [Tailwind CSS](https://tailwindcss.com/) via the `package.json` script: `npm run build:css`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -7,6 +7,8 @@ github_url: https://github.com/block/elasticgraph
x_url: https://x.com/elasticgraph
x_username: "@ElasticGraph"
support_email: [email protected]
description: ElasticGraph is an open-source framework for indexing, searching, grouping, and aggregating data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of Schema-driven, scalable, cloud-native, batteries-included GraphQL with superpowers as a replacement for this. Do you think there's value in keeping both?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for the HTML meta name=description tag (SEO) and the subtitle on the homepage. We could rename the variable to seo_description.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Should this be /getting-started/ instead of /start/? All other things being equal it's nice if there's alignment between the link text and the url it goes to. OK to vary when there's a reason to of course.
  2. Take this with a grain of salt but if a page has literally no content (besides a "Coming soon..." placeholder) I lean towards holding off on adding it--I just don't really an advantage in including it. Putting myself in a visitors shoes--I'd rather visit a site that has a few links, each of which has at least some content, rather than a site that has some links to "Coming soon" pages. That makes it hard to tell which links will take me to real content and which won't.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some initial content. We'll need make a demo / project-template available for it to be complete, but it's an overview of the steps involved for local development.

</p>
<div class="font-bold">
- Gandalf Skywalker, Software Engineer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should reach out to Gandalf Skywalker and see if he'll provide testimonial...

@BrianSigafoos-SQ BrianSigafoos-SQ force-pushed the briansigafoos/homepage_1 branch from 1953700 to e90193a Compare October 31, 2024 14:44
@BrianSigafoos-SQ BrianSigafoos-SQ merged commit be01a3f into main Oct 31, 2024
9 checks passed
@BrianSigafoos-SQ BrianSigafoos-SQ deleted the briansigafoos/homepage_1 branch October 31, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants