Consistent Ruby version in GitHub workflows / rubocop + Fix amazonlinux build #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ithanil
changed the title
Ithanil
force-pushed
the
consistent_rubyv
branch
2 times, most recently
from
71a1643 to
8f2cbce
Compare
Ithanil
force-pushed
the
consistent_rubyv
branch
from
8f2cbce to
f7f090e
Compare
Ithanil
force-pushed
the
consistent_rubyv
branch
6 times, most recently
from
84ce796 to
2a06962
Compare
Ithanil
force-pushed
the
consistent_rubyv
branch
from
2a06962 to
7eee90c
Compare
Ithanil
changed the title
Ithanil
changed the title
Ithanil
force-pushed
the
consistent_rubyv
branch
from
7eee90c to
29018f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consistent Ruby version in Github workflows / rubocop (including trivial adaptions).
Description
By working on GL3 I got remembered of the fact that the Ruby version is specified in more of the Github workflow files besides just the
ci.yml, although the variable is not obviously used in any way in these files. Nevertheless, this PR makes the specified Ruby version consistent in these files. Also, the Ruby version target for Rubocop is adapted, including some trivial suggested changes.The problem with the GitHub workflow files is also that there seems to be a lot of redundancy, but I'm not very familiar with the GitHub CI system since I'm generally using GitLab CI for test,build,push and thus won't touch that.
Another thing that apparently needs to be addressed is the whole amazonlinux build, which is currently failing due to Ruby being stuck on 3.0 there. I think the build needs to switch to a custom Ruby installation e.g. via rbenv and should soon be migrated from AL2 to AL2023 (for which I've read that support Ruby 3.3 is coming very soon or is already there).EDIT: Now this PR also fixes the amazonlinux build, by using rbenv to install Ruby 3.3. The point of upgrading to AL2023 still stands. @paulseto , I have seen a PR from you regarding the amazonlinux build in the past. Would you be able and willing to work on this?