Fixed #32285 -- Raised ImproperlyConfigured when AppConfig.label is n…

…ot a valid Python identifier.
blighj · Dec 22, 2020 · 8b2a30f · 8b2a30f
1 parent 110001d
commit 8b2a30f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/django/apps/config.py b/django/apps/config.py
@@ -34,6 +34,10 @@ def __init__(self, app_name, app_module):
         # This value must be unique across a Django project.
         if not hasattr(self, 'label'):
             self.label = app_name.rpartition(".")[2]
+        if not self.label.isidentifier():
+            raise ImproperlyConfigured(
+                "The app label '%s' is not a valid Python identifier." % self.label
+            )
 
         # Human-readable name for the application e.g. "Admin".
         if not hasattr(self, 'verbose_name'):

diff --git a/tests/apps/tests.py b/tests/apps/tests.py
@@ -436,6 +436,14 @@ def test_repr(self):
         ac = AppConfig('label', Stub(__path__=['a']))
         self.assertEqual(repr(ac), '<AppConfig: label>')
 
+    def test_invalid_label(self):
+        class MyAppConfig(AppConfig):
+            label = 'invalid.label'
+
+        msg = "The app label 'invalid.label' is not a valid Python identifier."
+        with self.assertRaisesMessage(ImproperlyConfigured, msg):
+            MyAppConfig('test_app', Stub())
+
     @override_settings(
         INSTALLED_APPS=['apps.apps.ModelPKAppsConfig'],
         DEFAULT_AUTO_FIELD='django.db.models.SmallAutoField',