Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CDN link in docs #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lmiller1990
Copy link

@lmiller1990 lmiller1990 commented Jun 26, 2018

Updated based on a issue someone asked on Stack Overflow

CDN link needs to also specify /dist/vue-rangedate-picker.min.js.

Test

<script src="https://cdnjs.cloudflare.com/ajax/libs/vue/2.5.13/vue.min.js">
</script>
<script src="https://unpkg.com/vue-rangedate-picker/dist/vue-rangedate-picker.min.js">
</script>

<div id="app">
  <vue-rangedate-picker
    @selected="onDateSelected" i18n="EN" format="YYYY-MM-DD hh:mm:ss">
  </vue-rangedate-picker>
</div>
</body>

<script>
document.addEventListener("DOMContentLoaded", () => {
  VueRangedatePicker.default.install(Vue)

  new Vue({
    el: "#app",
    methods: {
      onDateSelected() {
      }
    }
  })
})
</script>
</html>

Removing dist/vue-rangedate-picker.min.js from the CDN causes it not to work.

cc @khannedy is your org still maintaining this repo? Happy to help out with some of the PRs that need to be merged (been a while since anything was updated) and to clean up issues, or fix the CI. Been using this component a bit. Would be sad to see it not maintained anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant