fix: convert environment variables to int #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMFY_POLLING_INTERVAL_MS and COMFY_POLLING_MAX_RETRIES should be integers.
TimPietrusky
approved these changes
Nov 10, 2024
TimPietrusky
changed the title
TimPietrusky
pushed a commit
that referenced
this pull request
Nov 10, 2024
## [3.1.2](3.1.1...3.1.2) (2024-11-10) ### Bug Fixes * convert environment variables to int ([#70](#70)) ([7ab3d2a](7ab3d2a))
|
🎉 This PR is included in version 3.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to ValerioB88/runpod-worker-comfy
that referenced
this pull request
Nov 18, 2024
# 1.0.0 (2024-11-18) ### Bug Fixes * check_server default values for delay and check-interval ([4945a9d](4945a9d)) * convert environment variables to int ([blib-la#70](https://github.com/ValerioB88/runpod-worker-comfy/issues/70)) ([7ab3d2a](7ab3d2a)) * create directories which are required to run ComfyUI ([blib-la#58](https://github.com/ValerioB88/runpod-worker-comfy/issues/58)) ([6edf62b](6edf62b)) * don’t persist credentials ([1546420](1546420)) * don't run ntpdate as this is not working in GitHub Actions ([2f7bd3f](2f7bd3f)) * got rid of syntax error ([c04de4d](c04de4d)) * images in subfolders are not working, fixes [blib-la#12](https://github.com/ValerioB88/runpod-worker-comfy/issues/12) ([37480c2](37480c2)) * path should be "loras" and not "lora" ([8e579f6](8e579f6)) * removed xl_more_art-full_v1 because civitai requires login now ([2e8e638](2e8e638)) * return the output of "process_output_image" and access jobId correctly ([blib-la#11](https://github.com/ValerioB88/runpod-worker-comfy/issues/11)) ([dc655ea](dc655ea)) * **semantic-release:** added .releaserc ([blib-la#21](https://github.com/ValerioB88/runpod-worker-comfy/issues/21)) ([12b763d](12b763d)) * updated path to "comfyui" ([37f66d0](37f66d0)) * use custom GITHUB_TOKEN to bypass branch protection ([9b6468a](9b6468a)) ### Features * added default ComfyUI workflow ([fa6c385](fa6c385)) * added FLUX.1 schnell & dev ([9170191](9170191)) * added runpod as local dependency ([9deae9f](9deae9f)) * added unit tests for everthing, refactored the code to make it better testable, added test images ([a7492ec](a7492ec)) * added xl_more_art-full_v1, improved comments ([9aea8ab](9aea8ab)) * base64 image output ([blib-la#8](https://github.com/ValerioB88/runpod-worker-comfy/issues/8)) ([76bf0b1](76bf0b1)) * example on how to configure the .env ([4ed5296](4ed5296)) * image-input, renamed "prompt" to "workflow", added "REFRESH_WORKER" ([blib-la#14](https://github.com/ValerioB88/runpod-worker-comfy/issues/14)) ([5f5e390](5f5e390)) * logs should be written to stdout so that we can see them inside the worker ([fc731ff](fc731ff)) * network-volume; execution time config; skip default images; access ComfyUI via web ([blib-la#35](https://github.com/ValerioB88/runpod-worker-comfy/issues/35)) ([070cde5](070cde5)), closes [blib-la#16](https://github.com/ValerioB88/runpod-worker-comfy/issues/16) * run the worker locally ([blib-la#19](https://github.com/ValerioB88/runpod-worker-comfy/issues/19)) ([34eb32b](34eb32b)) * simplified input ([35c2341](35c2341)) * simplified input to just have "prompt", removed unused code ([0c3ccda](0c3ccda)) * support sd3 ([blib-la#46](https://github.com/ValerioB88/runpod-worker-comfy/issues/46)) ([dde69d6](dde69d6)) * updated path to "comfyui", added "ntpdate" to have the time of the container in sync with AWS ([2fda578](2fda578)) * use local ".env" to load env variables, mount "comfyui/output" to localhost so that people can see the generated images ([aa645a2](aa645a2)) * use models from huggingface, not from local folder ([b1af369](b1af369)) * wait until server is ready, wait until image generation is done, upload to s3 ([ecfec13](ecfec13)) ### BREAKING CHANGES * we have 3 different images now instead of just one: base, sdxl and sd3 * ci: use branch name for creating dev releases * ci: replace "/" with "-" to have a valid tag name * ci: correctly handle the tag name * ci: build an image that contains sd3 using docker bake * ci: use "set" instead of "args" * ci: use "env" instead of "set" * ci: use variables instead of args * ci: set variables directly for the targets * ci: write the secrets into the GITHUB_ENV * ci: handle env variables correctly * ci: use env variables from GitHub Variables * ci: added back to env * ci: print out env * ci: adding the vars directly into the workflow * ci: example workflow for sd3 * ci: renamed DOCKERHUB_REPO to DOCKERHUB_REPOSITORY * ci: removed quotes for DOCKERHUB_REPOSITORY * ci: only use DOCKERHUB_REPO in bake * ci: added vars into sd3 target * ci: added direct target * ci: back to basics * ci: multi-stage build to not expose the HUGGINGFACE_ACCESS_TOKEN * ci: write everything into GITHUB_ENV again * ci: use correct name for final stage * ci: use correct runner * fix: make sure to use the latest versions of all packages * ci: simplified variables for all targets * docs: added 3 images, updated build your own image * docs: updated TOC * ci: updated name * ci: use docker bake to publish 3 images instead of just 1
Calvin-Huang
pushed a commit
to gazai-io/runpod-worker-comfy
that referenced
this pull request
Nov 26, 2024
* convert environment variables to int COMFY_POLLING_INTERVAL_MS and COMFY_POLLING_MAX_RETRIES should be integers. * chore: remove unnecessary comment --------- Co-authored-by: NERDDISCO <[email protected]>
Calvin-Huang
pushed a commit
to gazai-io/runpod-worker-comfy
that referenced
this pull request
Nov 26, 2024
## [3.1.2](blib-la/runpod-worker-comfy@3.1.1...3.1.2) (2024-11-10) ### Bug Fixes * convert environment variables to int ([blib-la#70](blib-la#70)) ([7ab3d2a](blib-la@7ab3d2a))
Calvin-Huang
pushed a commit
to gazai-io/runpod-worker-comfy
that referenced
this pull request
Dec 2, 2024
* convert environment variables to int COMFY_POLLING_INTERVAL_MS and COMFY_POLLING_MAX_RETRIES should be integers. * chore: remove unnecessary comment --------- Co-authored-by: NERDDISCO <[email protected]>
Calvin-Huang
pushed a commit
to gazai-io/runpod-worker-comfy
that referenced
this pull request
Dec 2, 2024
## [3.1.2](blib-la/runpod-worker-comfy@3.1.1...3.1.2) (2024-11-10) ### Bug Fixes * convert environment variables to int ([blib-la#70](blib-la#70)) ([7ab3d2a](blib-la@7ab3d2a))
SzabyV
pushed a commit
to SzabyV/runpod-worker-comfy
that referenced
this pull request
Dec 4, 2024
# 1.0.0 (2024-12-04) ### Bug Fixes * added missing start command ([9a7ffdb](9a7ffdb)) * check_server default values for delay and check-interval ([4945a9d](4945a9d)) * convert environment variables to int ([blib-la#70](https://github.com/SzabyV/runpod-worker-comfy/issues/70)) ([7ab3d2a](7ab3d2a)) * create directories which are required to run ComfyUI ([blib-la#58](https://github.com/SzabyV/runpod-worker-comfy/issues/58)) ([6edf62b](6edf62b)) * don’t persist credentials ([1546420](1546420)) * don't run ntpdate as this is not working in GitHub Actions ([2f7bd3f](2f7bd3f)) * got rid of syntax error ([c04de4d](c04de4d)) * images in subfolders are not working, fixes [blib-la#12](https://github.com/SzabyV/runpod-worker-comfy/issues/12) ([37480c2](37480c2)) * path should be "loras" and not "lora" ([8e579f6](8e579f6)) * removed xl_more_art-full_v1 because civitai requires login now ([2e8e638](2e8e638)) * return the output of "process_output_image" and access jobId correctly ([blib-la#11](https://github.com/SzabyV/runpod-worker-comfy/issues/11)) ([dc655ea](dc655ea)) * **semantic-release:** added .releaserc ([blib-la#21](https://github.com/SzabyV/runpod-worker-comfy/issues/21)) ([12b763d](12b763d)) * start the container in all cases ([413707b](413707b)) * update the version inside of semanticrelease ([d93e991](d93e991)) * updated path to "comfyui" ([37f66d0](37f66d0)) * use custom GITHUB_TOKEN to bypass branch protection ([9b6468a](9b6468a)) ### Features * added default ComfyUI workflow ([fa6c385](fa6c385)) * added FLUX.1 schnell & dev ([9170191](9170191)) * added runpod as local dependency ([9deae9f](9deae9f)) * added sensible defaults and default platform ([3f5162a](3f5162a)) * added unit tests for everthing, refactored the code to make it better testable, added test images ([a7492ec](a7492ec)) * added xl_more_art-full_v1, improved comments ([9aea8ab](9aea8ab)) * automatically update latest version ([7d846e8](7d846e8)) * base64 image output ([blib-la#8](https://github.com/SzabyV/runpod-worker-comfy/issues/8)) ([76bf0b1](76bf0b1)) * example on how to configure the .env ([4ed5296](4ed5296)) * image-input, renamed "prompt" to "workflow", added "REFRESH_WORKER" ([blib-la#14](https://github.com/SzabyV/runpod-worker-comfy/issues/14)) ([5f5e390](5f5e390)) * logs should be written to stdout so that we can see them inside the worker ([fc731ff](fc731ff)) * network-volume; execution time config; skip default images; access ComfyUI via web ([blib-la#35](https://github.com/SzabyV/runpod-worker-comfy/issues/35)) ([070cde5](070cde5)), closes [blib-la#16](https://github.com/SzabyV/runpod-worker-comfy/issues/16) * run the worker locally ([blib-la#19](https://github.com/SzabyV/runpod-worker-comfy/issues/19)) ([34eb32b](34eb32b)) * simplified and added compatibility with Windows ([9f41231](9f41231)) * simplified input ([35c2341](35c2341)) * simplified input to just have "prompt", removed unused code ([0c3ccda](0c3ccda)) * support sd3 ([blib-la#46](https://github.com/SzabyV/runpod-worker-comfy/issues/46)) ([dde69d6](dde69d6)) * updated path to "comfyui", added "ntpdate" to have the time of the container in sync with AWS ([2fda578](2fda578)) * use local ".env" to load env variables, mount "comfyui/output" to localhost so that people can see the generated images ([aa645a2](aa645a2)) * use models from huggingface, not from local folder ([b1af369](b1af369)) * wait until server is ready, wait until image generation is done, upload to s3 ([ecfec13](ecfec13)) ### BREAKING CHANGES * we have 3 different images now instead of just one: base, sdxl and sd3 * ci: use branch name for creating dev releases * ci: replace "/" with "-" to have a valid tag name * ci: correctly handle the tag name * ci: build an image that contains sd3 using docker bake * ci: use "set" instead of "args" * ci: use "env" instead of "set" * ci: use variables instead of args * ci: set variables directly for the targets * ci: write the secrets into the GITHUB_ENV * ci: handle env variables correctly * ci: use env variables from GitHub Variables * ci: added back to env * ci: print out env * ci: adding the vars directly into the workflow * ci: example workflow for sd3 * ci: renamed DOCKERHUB_REPO to DOCKERHUB_REPOSITORY * ci: removed quotes for DOCKERHUB_REPOSITORY * ci: only use DOCKERHUB_REPO in bake * ci: added vars into sd3 target * ci: added direct target * ci: back to basics * ci: multi-stage build to not expose the HUGGINGFACE_ACCESS_TOKEN * ci: write everything into GITHUB_ENV again * ci: use correct name for final stage * ci: use correct runner * fix: make sure to use the latest versions of all packages * ci: simplified variables for all targets * docs: added 3 images, updated build your own image * docs: updated TOC * ci: updated name * ci: use docker bake to publish 3 images instead of just 1
BlacktailAi
pushed a commit
to BlacktailAi/blacktail-comfyui-worker
that referenced
this pull request
Dec 6, 2024
# 1.0.0 (2024-12-06) ### Bug Fixes * added missing start command ([9a7ffdb](9a7ffdb)) * check_server default values for delay and check-interval ([4945a9d](4945a9d)) * convert environment variables to int ([blib-la#70](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/70)) ([7ab3d2a](7ab3d2a)) * create directories which are required to run ComfyUI ([blib-la#58](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/58)) ([6edf62b](6edf62b)) * don’t persist credentials ([1546420](1546420)) * don't run ntpdate as this is not working in GitHub Actions ([2f7bd3f](2f7bd3f)) * got rid of syntax error ([c04de4d](c04de4d)) * images in subfolders are not working, fixes [blib-la#12](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/12) ([37480c2](37480c2)) * path should be "loras" and not "lora" ([8e579f6](8e579f6)) * removed xl_more_art-full_v1 because civitai requires login now ([2e8e638](2e8e638)) * return the output of "process_output_image" and access jobId correctly ([blib-la#11](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/11)) ([dc655ea](dc655ea)) * **semantic-release:** added .releaserc ([blib-la#21](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/21)) ([12b763d](12b763d)) * start the container in all cases ([413707b](413707b)) * update the version inside of semanticrelease ([d93e991](d93e991)) * updated path to "comfyui" ([37f66d0](37f66d0)) * use custom GITHUB_TOKEN to bypass branch protection ([9b6468a](9b6468a)) ### Features * added default ComfyUI workflow ([fa6c385](fa6c385)) * added FLUX.1 schnell & dev ([9170191](9170191)) * added runpod as local dependency ([9deae9f](9deae9f)) * added sensible defaults and default platform ([3f5162a](3f5162a)) * added unit tests for everthing, refactored the code to make it better testable, added test images ([a7492ec](a7492ec)) * added xl_more_art-full_v1, improved comments ([9aea8ab](9aea8ab)) * automatically update latest version ([7d846e8](7d846e8)) * base64 image output ([blib-la#8](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/8)) ([76bf0b1](76bf0b1)) * example on how to configure the .env ([4ed5296](4ed5296)) * image-input, renamed "prompt" to "workflow", added "REFRESH_WORKER" ([blib-la#14](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/14)) ([5f5e390](5f5e390)) * logs should be written to stdout so that we can see them inside the worker ([fc731ff](fc731ff)) * network-volume; execution time config; skip default images; access ComfyUI via web ([blib-la#35](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/35)) ([070cde5](070cde5)), closes [blib-la#16](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/16) * run the worker locally ([blib-la#19](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/19)) ([34eb32b](34eb32b)) * simplified and added compatibility with Windows ([9f41231](9f41231)) * simplified input ([35c2341](35c2341)) * simplified input to just have "prompt", removed unused code ([0c3ccda](0c3ccda)) * support sd3 ([blib-la#46](https://github.com/BlacktailAi/blacktail-comfyui-worker/issues/46)) ([dde69d6](dde69d6)) * updated path to "comfyui", added "ntpdate" to have the time of the container in sync with AWS ([2fda578](2fda578)) * use local ".env" to load env variables, mount "comfyui/output" to localhost so that people can see the generated images ([aa645a2](aa645a2)) * use models from huggingface, not from local folder ([b1af369](b1af369)) * wait until server is ready, wait until image generation is done, upload to s3 ([ecfec13](ecfec13)) ### BREAKING CHANGES * we have 3 different images now instead of just one: base, sdxl and sd3 * ci: use branch name for creating dev releases * ci: replace "/" with "-" to have a valid tag name * ci: correctly handle the tag name * ci: build an image that contains sd3 using docker bake * ci: use "set" instead of "args" * ci: use "env" instead of "set" * ci: use variables instead of args * ci: set variables directly for the targets * ci: write the secrets into the GITHUB_ENV * ci: handle env variables correctly * ci: use env variables from GitHub Variables * ci: added back to env * ci: print out env * ci: adding the vars directly into the workflow * ci: example workflow for sd3 * ci: renamed DOCKERHUB_REPO to DOCKERHUB_REPOSITORY * ci: removed quotes for DOCKERHUB_REPOSITORY * ci: only use DOCKERHUB_REPO in bake * ci: added vars into sd3 target * ci: added direct target * ci: back to basics * ci: multi-stage build to not expose the HUGGINGFACE_ACCESS_TOKEN * ci: write everything into GITHUB_ENV again * ci: use correct name for final stage * ci: use correct runner * fix: make sure to use the latest versions of all packages * ci: simplified variables for all targets * docs: added 3 images, updated build your own image * docs: updated TOC * ci: updated name * ci: use docker bake to publish 3 images instead of just 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMFY_POLLING_INTERVAL_MS and COMFY_POLLING_MAX_RETRIES should be integers.
Motivation
fix conversion of environment variables to integers
Issues closed
fixes #68