This repository has been archived by the owner on Sep 4, 2019. It is now read-only.
Corrected the variable name in jnext to prevent reference errors. #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has the webplatform updated this file at all? |
|
@jeffheifetz Webplatform does not have jnext module or .so. |
|
Unless things have changed wildly, thats still where the source for jnext lives |
|
I just checked that jnext under webplatform is using correct variable names. |
|
r+ |
| @@ -138,7 +138,7 @@ function JNEXT_() { | |||
|
|
|||
| var objNotify = self.m_arEvents[strObjId]; | |||
| if( typeof (objNotify) == 'undefined') { | |||
| alert("Warning: No object with Id " + strId + " found for event " + strEvent); | |||
| alert("Warning: No object with Id " + strObjId + " found for event " + strEvent); | |||
There was a problem hiding this comment.
Can we change this from alert to console.log, its far less intrusive.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.