-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add installer(Ver 1.5) #93
Conversation
LGTM Can only README.org updates be reverted? |
Just merge and then I'll do it. |
@black7375 Thanks for letting me contribute! |
@black7375 OK. I’ll review my code thoroughly and will post an issue mentioning it before PRing. |
@black7375 I’m deeply sorry if you were annoyed by by spammy pull requests. |
@black7375 I found a compatibility issue with the installer script. Would you please add a dot after find in install.sh? I’ve found out that FreeBSD/MacOS wont’t work when the command is |
This will be corrected later. To be honest, I want you to refrain from excessive mentions and comments that are divided into several. Even in non-essential situations, notifications from the Github app are sent immediately every time, and it clutters up the notification window of the person who pressed watch on the project. Finally, don't be swear word.
That's why I added CODE_OF_CONDUCT. You may not have been aware of it, and I think you can fix it from now on. |
In #87 where @travisnewman mentioned https://github.com/ideaweb/firefox-safari-style , the project says:
What this means is that if the user has already cloned the repository, fast-forwarding to the current repository and re-running
./install.sh
is how to update the theme, so I have concluded that embeddinggit pull
in the script is not needed since people who downloaded the.zip
would not have the.git
folder, so it would be very confusing and will error out. That will be anoadd
.#48 is considerable, but needs a large amount of
if
s to implement and is a nice-to-have that is not necessary.How about merging this first, and adding the nice-to-haves later on since I am not your exclusive shell scripter.