Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add installer(Ver 1.5) #93

Merged
merged 10 commits into from Jun 14, 2021
Merged

Add installer(Ver 1.5) #93

merged 10 commits into from Jun 14, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 14, 2021

In #87 where @travisnewman mentioned https://github.com/ideaweb/firefox-safari-style , the project says:

To update please just run git pull in the cloned repository or just re-download it.

What this means is that if the user has already cloned the repository, fast-forwarding to the current repository and re-running ./install.sh is how to update the theme, so I have concluded that embedding git pull in the script is not needed since people who downloaded the .zip would not have the .git folder, so it would be very confusing and will error out. That will be a noadd.

#48 is considerable, but needs a large amount of ifs to implement and is a nice-to-have that is not necessary.

How about merging this first, and adding the nice-to-haves later on since I am not your exclusive shell scripter.

@black7375
Copy link
Owner

black7375 commented Jun 14, 2021

LGTM

Can only README.org updates be reverted?
I'd like to update the document with 2.0 released.

@black7375
Copy link
Owner

Just merge and then I'll do it.

@black7375 black7375 merged commit 35f40be into black7375:master Jun 14, 2021
@ghost
Copy link
Author

ghost commented Jun 14, 2021

@black7375 Thanks for letting me contribute!

@black7375
Copy link
Owner

From now on, please do not post the same PR repeatedly. #39 #42 #44 #60 #61
It's like spam.

@ghost
Copy link
Author

ghost commented Jun 14, 2021

@black7375 OK. I’ll review my code thoroughly and will post an issue mentioning it before PRing.

@ghost
Copy link
Author

ghost commented Jun 14, 2021

@black7375 I’m deeply sorry if you were annoyed by by spammy pull requests.

@ghost
Copy link
Author

ghost commented Jun 14, 2021

@black7375 I found a compatibility issue with the installer script. Would you please add a dot after find in install.sh? I’ve found out that FreeBSD/MacOS wont’t work when the command is find -maxdepth 1 instead of find . -maxdepth 1(SC2185).

@black7375
Copy link
Owner

black7375 commented Jun 14, 2021

I found a compatibility issue with the installer script. Would you please add a dot after find in install.sh? I’ve found out that FreeBSD/MacOS wont’t work when the command is find -maxdepth 1 instead of find . -maxdepth 1(SC2185).

This will be corrected later.


To be honest, I want you to refrain from excessive mentions and comments that are divided into several.

Even in non-essential situations, notifications from the Github app are sent immediately every time, and it clutters up the notification window of the person who pressed watch on the project.
Each comment can be edited, so I think it's best to make the most of it.

Finally, don't be swear word.
#60 (comment)

wtf I wait I didn't mean to do that

That's why I added CODE_OF_CONDUCT.

You may not have been aware of it, and I think you can fix it from now on.

black7375 added a commit that referenced this pull request Jun 17, 2021
This reverts commit 35f40be, reversing
changes made to f20b74a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Install Problems in the installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant