linting fixes

bl-sdk · Sep 21, 2023 · 8e89563 · 8e89563
1 parent eac20b5
commit 8e89563
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/unrealsdk/game/bl3/bl3.cpp b/src/unrealsdk/game/bl3/bl3.cpp
@@ -263,6 +263,9 @@ void BL3Hook::find_ftext_as_culture_invariant(void) {
     LOG(MISC, "FText::AsCultureInvariant: {:p}", reinterpret_cast<void*>(fname_init_ptr));
 }
 
+// This is fine, since we consume it when calling the native function
+// The rvalue will live for the lifetime of this function call
+// NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved)
 void BL3Hook::ftext_as_culture_invariant(FText* text, TemporaryFString&& str) const {
     ftext_as_culture_invariant_ptr(text, &str);
 }

diff --git a/src/unrealsdk/unreal/structs/gobjects.cpp b/src/unrealsdk/unreal/structs/gobjects.cpp
@@ -11,7 +11,8 @@ FUObjectItem* FChunkedFixedUObjectArray::at(size_t idx) const {
         throw std::out_of_range("FChunkedFixedUObjectArray index out of range");
     }
     // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-pointer-arithmetic)
-    return &this->Objects[idx / this->NumElementsPerChunk][idx % this->NumElementsPerChunk];
+    return &this->Objects[idx / FChunkedFixedUObjectArray::NumElementsPerChunk]
+                         [idx % FChunkedFixedUObjectArray::NumElementsPerChunk];
 };
 
 #endif