New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle parentheses in variables in commands #526

Open

i7an wants to merge 1 commit into bkeepers:main from i7an:handle-parentheses

i7an commented Jan 8, 2025 •

edited

Loading

Variables with parentheses are not handled correctly in commands:

FOO='passwo(rd'
BAR=$(echo '$FOO')

Result:

expected: {"BAR"=>"passwo(rd",           "FOO"=>"passwo(rd"}
     got: {"BAR"=>"$(echo 'passwo(rd')", "FOO"=>"passwo(rd"}

The solution I suggest is to parse commands first and expand variables before executing commands.

Dependencies

This change will break kamal which is included in Rails by default. This is how I want to handle it:

Get an approval for the dotenv patch but not merge it.
Deliver backward compatible fix to kamal Handle parentheses in variables in commands basecamp/kamal#1346
Merge this PR once the patched version of kamal is released.


          Handle parentheses in variables in commands

9cb999e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet