Add option to configure support for custom ObjectMapper's #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public Config(ObjectMapper mapper) { | ||
| if (mapper == null) { | ||
| throw new RuntimeException("ObjectMapper instance cannot be null"); |
There was a problem hiding this comment.
Could be IllegelArgumentException instead of RuntimeException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue#22
More direct option would be to allow manipulating the mapper from GeoJSONFactory instead of using a custom Config. However, I decided to add 1 level of custom api over exposing the Jackson internals directly since it was hidden from the entire API thus far.